Add OAuthConsent and useOAuthConsent docs#3315
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@wobsoriano have submitted a docs review with some minor changes:
Let me know what you think, and left some comments too! |
Yeah I was in the same boat yesterday debating whether it should be in |
@wobsoriano @alexisintech just pushed a commit to make OAuthApplication a type rather than an object. Let me know thoughts! |
|
|
||
| --- | ||
|
|
||
| - `oauthApplication` |
There was a problem hiding this comment.
so it does exist on the clerk object, so it's fine to keep it here. i just meant that it doesn't need be in /objects and under objects in the manifest!
There was a problem hiding this comment.
also, towards the bottom there's a section called "Components"
it will need a section for mountOAuthConsent and unmountOAuthconsent like the other components listed there!
There was a problem hiding this comment.
|
could you please add all the relevant links added to the PR description here? any JS repo PR's that were related to releasing this future, and the PR's that were related to typedoc changes |
@wobsoriano have added the Typedoc PRs related to this but I'll let you add the JS repo PR'S related to releasing this feature. |
|
Okay @wobsoriano @alexisintech this is ready for a final review! |
|
right now, the callout about setting the referrer policy is in the intro section for the component, but the returns section for the hook - was there any specific reasoning behind having it in the returns section for the hook? |
alexisintech
left a comment
There was a problem hiding this comment.
small comment about the placement of the callout for setting the referrer policy but its non-blocking, so i'm going to approve!
i've tested all the links, and all links embedded in those pages, everything looks to be working! thanks for the hard work on this guys 🫶
Have updated the wording of the callout here, but yeah got the same question @wobsoriano - I'd be keen to make the placement consistent before merging this. |
🔎 Previews:
What does this solve? What changed?
We will now allow C1s to configure a custom OAuth consent page where they can use a custom hook, or the new drop-in
<OAuthConsent />componentDeadline
Other resources